Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace NUnique get_function #434

Merged
merged 5 commits into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Feb 14, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #434 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   96.33%   96.29%   -0.04%     
==========================================
  Files          93       93              
  Lines        8450     8455       +5     
==========================================
+ Hits         8140     8142       +2     
- Misses        310      313       +3
Impacted Files Coverage Δ
...ools/primitives/standard/aggregation_primitives.py 94.66% <50%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2e649...790c9fa. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 15, 2019

Copy link
Member

kmax12 left a comment

LGTM

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Feb 15, 2019

Actually, looks let's test are failing in 2.7. might have to use a different function

@kmax12 kmax12 merged commit 15b7dae into master Feb 15, 2019

1 of 3 checks passed

codecov/patch 50% of diff hit (target 96.33%)
Details
codecov/project 96.29% (-0.04%) compared to 6a2e649
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.