Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More manifest fixes #445

Merged
merged 3 commits into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Feb 20, 2019

Adds more files necessary for test cases to the manifest file. Also adds a test case for installing primitives via a local gzip archive.

@codecov

This comment has been minimized.

Copy link

commented Feb 20, 2019

Codecov Report

Merging #445 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   96.33%   96.31%   -0.03%     
==========================================
  Files          95       96       +1     
  Lines        8539     8543       +4     
==========================================
+ Hits         8226     8228       +2     
- Misses        313      315       +2
Impacted Files Coverage Δ
...s/tests/primitive_tests/test_install_primitives.py 98.94% <100%> (+0.01%) ⬆️
...itives_to_install/featuretools_pip_tester/setup.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe29479...393f0c4. Read the comment docs.

@kmax12 kmax12 self-requested a review Feb 20, 2019

@kmax12

kmax12 approved these changes Feb 20, 2019

Copy link
Member

left a comment

LGTM

@rwedge rwedge merged commit 3f883ea into master Feb 20, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.33%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +3.66% compared to fe29479
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the more-manifest-fixes branch Feb 20, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.