Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test featuretools on CI using packaged source files #459

Merged
merged 26 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@rwedge
Copy link
Contributor

commented Mar 11, 2019

Fixes #442

@codecov

This comment has been minimized.

Copy link

commented Mar 11, 2019

Codecov Report

Merging #459 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   96.48%   96.49%   +<.01%     
==========================================
  Files          99      102       +3     
  Lines        8675     8693      +18     
==========================================
+ Hits         8370     8388      +18     
  Misses        305      305
Impacted Files Coverage Δ
featuretools/selection/__init__.py 100% <0%> (ø)
featuretools/wrappers/__init__.py 100% <0%> (ø)
featuretools/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86b6d8...e9e2625. Read the comment docs.

rwedge added some commits Mar 11, 2019

FEATURETOOLS_VERSION=$(python setup.py --version)
pip install -e "featuretools-${FEATURETOOLS_VERSION}/"
pip install -r "featuretools-${FEATURETOOLS_VERSION}/test-requirements.txt"
pip install -r dev-requirements.txt

This comment has been minimized.

Copy link
@gsheni

gsheni Mar 12, 2019

Contributor

Dev requirements installs test-requirements.
So it seems like the test-requirements install is redundant.
https://github.com/Featuretools/featuretools/blob/master/dev-requirements.txt#L1

@gsheni

gsheni approved these changes Mar 14, 2019

Show resolved Hide resolved .circleci/config.yml Outdated

@kmax12 kmax12 self-requested a review Mar 14, 2019

rwedge added some commits Mar 14, 2019

Merge branch 'test-ci-with-packaged-featuretools' of github.com:Featu…
…retools/featuretools into test-ci-with-packaged-featuretools

@rwedge rwedge changed the title [WIP] Test featuretools on CI using packaged source files Test featuretools on CI using packaged source files Mar 15, 2019

@rwedge rwedge merged commit 6feaf93 into master Mar 15, 2019

3 checks passed

codecov/patch Coverage not affected when comparing a86b6d8...e9e2625
Details
codecov/project 96.49% (+<.01%) compared to a86b6d8
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the test-ci-with-packaged-featuretools branch Mar 15, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.