Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Haversine Primitive #462

Merged
merged 7 commits into from Mar 18, 2019

Conversation

Projects
None yet
1 participant
@gsheni
Copy link
Contributor

commented Mar 12, 2019

For Earth, the mean radius is 6,371.0088 km (3,958.7613 mi).

gsheni added some commits Mar 12, 2019

Update transform_primitive.py
Fix radius of earth

@gsheni gsheni changed the title Update transform_primitive.py [WIP] Update transform_primitive.py Mar 12, 2019

@gsheni gsheni changed the title [WIP] Update transform_primitive.py Update transform_primitive.py Mar 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         102      102           
  Lines        8693     8693           
=======================================
  Hits         8388     8388           
  Misses        305      305
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6feaf93...94e1e70. Read the comment docs.

gsheni added some commits Mar 12, 2019

@kmax12 kmax12 changed the title Update transform_primitive.py Update Haversine Primitive Mar 14, 2019

@gsheni gsheni merged commit f6b16bf into master Mar 18, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.49%)
Details
codecov/project 96.49% (+0%) compared to 6feaf93
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the haversine_fix branch Mar 18, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.