Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primitive_base.py #468

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Mar 20, 2019

  • We make a variable called method in the primitive base. However, this should be named _method so that it does not conflict with any primitive parameters.

gsheni added some commits Mar 20, 2019

@gsheni gsheni self-assigned this Mar 20, 2019

@gsheni gsheni requested review from kmax12 and CharlesBradshaw Mar 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 20, 2019

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         102      102           
  Lines        8724     8724           
=======================================
  Hits         8396     8396           
  Misses        328      328
Impacted Files Coverage Δ
featuretools/primitives/base/primitive_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a947...ae60e62. Read the comment docs.

@kmax12

kmax12 approved these changes Mar 20, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit 9f4858f into master Mar 20, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.24%)
Details
codecov/project 96.24% (+0%) compared to 2b6a947
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the rename_base_attribute branch Mar 20, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.