New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix EntitySet.combine_variables and standardize encode_features #47

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
3 participants
@rwedge
Contributor

rwedge commented Dec 20, 2017

Small fix to EntiytSet.combine_variables, and a change to encode_features so that the list of top n most common values for a categorical will be sorted first by value count and second by value name.

@codecov-io

This comment has been minimized.

codecov-io commented Dec 20, 2017

Codecov Report

Merging #47 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   87.14%   87.14%   +<.01%     
==========================================
  Files          74       74              
  Lines        6937     6946       +9     
==========================================
+ Hits         6045     6053       +8     
- Misses        892      893       +1
Impacted Files Coverage Δ
synthesis/encode_features.py 93.61% <0%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a80d7...faa08cd. Read the comment docs.

@kmax12 kmax12 merged commit 551b2f9 into master Dec 20, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 referenced this pull request Dec 20, 2017

Merged

v0.1.16 - Python 3 Support #48

@kmax12 kmax12 deleted the python3-fixes branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment