Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePath #470

Merged
merged 2 commits into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@glentennis
Copy link
Contributor

commented Mar 21, 2019

Adding new variable type called FilePath

Am I correct to place this under sessions in the entity set tests? I wasn't sure where it should go.

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #470 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   96.29%   96.29%   +<.01%     
==========================================
  Files         103      103              
  Lines        8845     8849       +4     
==========================================
+ Hits         8517     8521       +4     
  Misses        328      328
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 87.85% <100%> (+0.08%) ⬆️
featuretools/variable_types/variable.py 98.17% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45d285...c08fadb. Read the comment docs.

@kmax12 kmax12 requested review from kmax12 and gsheni and removed request for kmax12 Mar 26, 2019

@gsheni

gsheni approved these changes Mar 26, 2019

@gsheni

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@glentennis sessions is the correct entity to place this in.

@gsheni gsheni merged commit f308195 into Featuretools:master Mar 26, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.29%)
Details
codecov/project 96.29% (+<.01%) compared to a45d285
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.