Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby dfs #472

Merged
merged 57 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Mar 22, 2019

Building off of #455, adds groupby parameter to DeepFeatureSynthesis and ft.dfs

rwedge added some commits Feb 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #472 into master will increase coverage by 0.01%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #472      +/-   ##
=========================================
+ Coverage   96.29%   96.3%   +0.01%     
=========================================
  Files         103     103              
  Lines        8849    8882      +33     
=========================================
+ Hits         8521    8554      +33     
  Misses        328     328
Impacted Files Coverage Δ
featuretools/tests/dfs_tests/test_dfs_method.py 98.41% <ø> (ø) ⬆️
featuretools/synthesis/dfs.py 73.91% <ø> (ø) ⬆️
featuretools/feature_base/feature_base.py 96.46% <100%> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.55% <100%> (+0.05%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 96.75% <96.55%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f308195...a0ec863. Read the comment docs.

@rwedge rwedge changed the base branch from grouby-transform-feature to master Mar 25, 2019

rwedge added some commits Mar 26, 2019

@kmax12
Copy link
Member

left a comment

Implementation looks good. Just a few minor comments then it should be good to merge

Show resolved Hide resolved docs/source/changelog.rst Outdated
Show resolved Hide resolved featuretools/tests/dfs_tests/test_deep_feature_synthesis.py
@kmax12

kmax12 approved these changes Mar 28, 2019

Copy link
Member

left a comment

LGTM

@rwedge rwedge merged commit da19f29 into master Mar 28, 2019

3 checks passed

codecov/patch 97.67% of diff hit (target 96.29%)
Details
codecov/project 96.3% (+0.01%) compared to f308195
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the groupby-dfs branch Mar 28, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.