Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove featuretools install command #475

Merged
merged 7 commits into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

commented Mar 28, 2019

We added a featuretools install command in #326 to allow installation of additional primitives. However, we now have a better way to do it using entry points implemented in #452. This PR removes the first way we implemented and keeps the new way only.

@kmax12 kmax12 requested a review from rwedge Mar 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 28, 2019

Codecov Report

Merging #475 into master will decrease coverage by 0.07%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage    96.3%   96.23%   -0.08%     
==========================================
  Files         103      100       -3     
  Lines        8882     8607     -275     
==========================================
- Hits         8554     8283     -271     
+ Misses        328      324       -4
Impacted Files Coverage Δ
featuretools/primitives/api.py 100% <ø> (ø) ⬆️
featuretools/synthesis/__init__.py 100% <ø> (ø) ⬆️
featuretools/__main__.py 0% <0%> (-80%) ⬇️
featuretools/__init__.py 66.66% <100%> (ø) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100% <100%> (ø)
featuretools/primitives/utils.py 96.47% <92.68%> (-3.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56afe50...65d69d6. Read the comment docs.

kmax12 and others added some commits Mar 29, 2019

@rwedge

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Looks good to me

@kmax12 kmax12 merged commit bbc2147 into master Mar 29, 2019

1 of 3 checks passed

codecov/patch 94.73% of diff hit (target 96.3%)
Details
codecov/project 96.23% (-0.08%) compared to 56afe50
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.