Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change groupby_transform_primitives parameter name to groupby_trans_primitives #476

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Mar 29, 2019

Changes the DeepFeatureSynthesis paramater to match the shortened naming style used with agg_primitives and trans_primitives

@codecov

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #476 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #476   +/-   ##
======================================
  Coverage    96.3%   96.3%           
======================================
  Files         103     103           
  Lines        8882    8882           
======================================
  Hits         8554    8554           
  Misses        328     328
Impacted Files Coverage Δ
featuretools/tests/dfs_tests/test_dfs_method.py 98.41% <ø> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.55% <ø> (ø) ⬆️
featuretools/synthesis/dfs.py 73.91% <ø> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 96.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da19f29...94895f3. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Mar 29, 2019

@kmax12

kmax12 approved these changes Mar 29, 2019

@rwedge rwedge merged commit 56afe50 into master Mar 29, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.3%)
Details
codecov/project 96.3% (+0%) compared to da19f29
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the groupby-trans-primitives branch Mar 29, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.