Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicates Fix #479

Merged
merged 11 commits into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@minkvsky
Copy link
Contributor

commented Apr 5, 2019

Fixes #467
I found the problem is caused while generating child_columns in es.get_pandas_data_slice;
I think a suitable solution is to adjust the vtypes of variable in relationship; On the other hand, now that we could change relationship.child_variable.id and relationship.parent_variable.id(es.add_relationship) in special case, we also standardize them as vtypes.Id or vtypes.Index

bukosabino and others added some commits Feb 11, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 5, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Apr 5, 2019

Codecov Report

Merging #479 into master will decrease coverage by 0.02%.
The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   96.25%   96.23%   -0.03%     
==========================================
  Files         102      104       +2     
  Lines        8607     8658      +51     
==========================================
+ Hits         8285     8332      +47     
- Misses        322      326       +4
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 87.85% <ø> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️
...etools/primitives/base/transform_primitive_base.py 100% <100%> (ø) ⬆️
featuretools/entityset/entityset.py 95.04% <100%> (ø) ⬆️
...ools/primitives/base/aggregation_primitive_base.py 100% <100%> (ø) ⬆️
.../tests/primitive_tests/test_make_agg_primitives.py 100% <100%> (ø)
...ests/primitive_tests/test_make_trans_primitives.py 84.61% <84.61%> (ø)
...computational_backends/calculate_feature_matrix.py 96.98% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf98910...edcf04e. Read the comment docs.

@gsheni gsheni changed the title Bugfix issue 467 Check for duplicates Fix Apr 5, 2019

@kmax12

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

hi @minkvsky this looks great. thank you for tracking it down.

before we can merge, can you add a test case to make sure the variable type conversion during add relationships happens correctly?

@minkvsky

This comment has been minimized.

Copy link
Contributor Author

commented on 9344bc1 Apr 6, 2019

I found the es_test.test_add_relationships_convert_type; So, instead of creating a new test case , I change the existing test case so this test take effect for this bug

@kmax12 kmax12 self-requested a review Apr 8, 2019

@kmax12

kmax12 approved these changes Apr 8, 2019

Copy link
Member

left a comment

Looks good to me. Thank you!

@minkvsky minkvsky closed this Apr 9, 2019

@kmax12 kmax12 reopened this Apr 9, 2019

@kmax12 kmax12 merged commit 23dc0b1 into Featuretools:master Apr 9, 2019

4 checks passed

codecov/patch 96.49% of diff hit (target 96.25%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +0.23% compared to cf98910
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.