Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how standard primitives are imported internally #482

Merged
merged 4 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

commented Apr 5, 2019

This PR updates how the standard primitives are imported to better support loading extra primitives from entry points.

As things stand, if a primitive is loaded from an entry point it overwrites the standard primitive.

With this PR, a user can still access the standard primitives using from featuretools.primitives.standard import PrimitiveName

kmax12 added some commits Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 5, 2019

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         100      102    +2     
  Lines        8607     8607           
=======================================
  Hits         8283     8283           
  Misses        324      324
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.73% <100%> (-0.02%) ⬇️
featuretools/primitives/api.py 100% <100%> (ø) ⬆️
featuretools/primitives/standard/api.py 100% <100%> (ø)
featuretools/primitives/standard/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30d842...ebd3150. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge Apr 5, 2019

@rwedge

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Usually we use an api.py file to manage the individual imports for a module and have __init__.py import everything from api.py.

kmax12 added some commits Apr 6, 2019

@rwedge

rwedge approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

Looks good

@kmax12 kmax12 merged commit cf98910 into master Apr 8, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.23%)
Details
codecov/project 96.23% (+0%) compared to c30d842
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@kmax12 kmax12 deleted the standard-primitive-import branch Apr 8, 2019

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.