Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entrypoints #483

Merged
merged 9 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

commented Apr 8, 2019

This PR introduces a decorator that can be used to allow other libraries to register entry points on Featuretools functions.

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #483 into master will increase coverage by 0.07%.
The diff coverage is 94.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   96.26%   96.34%   +0.07%     
==========================================
  Files         104      106       +2     
  Lines        8727     8802      +75     
==========================================
+ Hits         8401     8480      +79     
+ Misses        326      322       -4
Impacted Files Coverage Δ
featuretools/utils/api.py 100% <100%> (ø) ⬆️
featuretools/tests/utils_tests/test_entry_point.py 100% <100%> (ø)
featuretools/synthesis/dfs.py 100% <100%> (+26.08%) ⬆️
featuretools/__init__.py 66.66% <25%> (ø) ⬆️
featuretools/utils/entry_point.py 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d58cdce...281933b. Read the comment docs.

kmax12 and others added some commits Apr 8, 2019

@rwedge

rwedge approved these changes Apr 8, 2019

kmax12 added some commits Apr 8, 2019

@kmax12 kmax12 merged commit 6fa74be into master Apr 15, 2019

3 of 4 checks passed

codecov/patch 94.25% of diff hit (target 96.26%)
Details
codecov/project 96.34% (+0.07%) compared to d58cdce
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

glentennis added a commit to glentennis/featuretools that referenced this pull request Apr 17, 2019

Refactor entrypoints (Featuretools#483)
* mostly implemented

* bump version

* add test for entry point decorator

* add test for positional args getting passed to entry_point.on_call

* add comment in test case about monkeypatch

* change version number to developmental version

* revert to 0.7.1

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.