Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AggregationPrimitive docstring updates #489

Merged
merged 39 commits into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@glentennis
Copy link
Contributor

commented Apr 11, 2019

Updating AggregationPrimitive docstrings to a new format with a longer description and doctests.

@glentennis glentennis changed the title AggregationPrimitive doctest updates AggregationPrimitive docstring updates Apr 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #489 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   96.09%   96.08%   -0.02%     
==========================================
  Files         108      108              
  Lines        8862     8864       +2     
==========================================
+ Hits         8516     8517       +1     
- Misses        346      347       +1
Impacted Files Coverage Δ
...uretools/tests/utils_tests/test_list_primitives.py 100% <ø> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️
...ools/primitives/standard/aggregation_primitives.py 94.49% <66.66%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14939d1...f1b3553. Read the comment docs.

@glentennis glentennis force-pushed the glentennis:AggregationPrimitive-doctests branch 2 times, most recently from 5e3b918 to b044fb8 Apr 11, 2019

@glentennis glentennis force-pushed the glentennis:AggregationPrimitive-doctests branch from f733dd7 to 926f7a0 Apr 11, 2019

glentennis added some commits Apr 11, 2019

@gsheni

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@glentennis can you fix the conflict?

glentennis and others added some commits Apr 12, 2019

@gsheni gsheni requested review from gsheni and kmax12 Apr 12, 2019

gsheni added some commits Apr 16, 2019

gsheni added some commits Apr 16, 2019

@gsheni

gsheni approved these changes Apr 16, 2019

gsheni added some commits Apr 16, 2019

@kmax12
Copy link
Member

left a comment

Left a few comment. Looking almost ready to merge

gsheni added some commits Apr 17, 2019

@gsheni

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Will merge in once #499 gets merged into master

@kmax12

kmax12 approved these changes Apr 18, 2019

Copy link
Member

left a comment

LGTM

gsheni added some commits Apr 18, 2019

WIP

@gsheni gsheni merged commit dd2a8e3 into Featuretools:master Apr 19, 2019

2 of 4 checks passed

codecov/patch 66.66% of diff hit (target 96.09%)
Details
codecov/project 96.08% (-0.02%) compared to 14939d1
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.