Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx Version #490

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@gsheni
Copy link
Contributor

commented Apr 11, 2019

  • Update sphinx and associated libraries version
  • Added Google docstring parsing settings of sphinx to conf.py

@gsheni gsheni self-assigned this Apr 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         104      104           
  Lines        8714     8714           
=======================================
  Hits         8388     8388           
  Misses        326      326

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40298ad...758b814. Read the comment docs.

@gsheni gsheni requested a review from rwedge Apr 11, 2019

@@ -8,6 +8,8 @@ isort==4.3.4
jupyter==1.0.0
matplotlib==3.0.2; python_version>'3.4'
matplotlib==2.2.3; python_version<'3'
nbconvert==5.4.1

This comment has been minimized.

Copy link
@rwedge

rwedge Apr 11, 2019

Contributor

jupyter==1.0.0 installs nbconvert

This comment has been minimized.

Copy link
@gsheni

gsheni Apr 11, 2019

Author Contributor

yes but nbsphinx does not want nbconvert==5.4.0
https://github.com/spatialaudio/nbsphinx/blob/master/setup.py#L18

@kmax12 kmax12 self-requested a review Apr 11, 2019

@kmax12

kmax12 approved these changes Apr 11, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit 62df835 into master Apr 12, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 40298ad...758b814
Details
codecov/project 96.25% remains the same compared to 40298ad
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the update_sphinx branch Apr 12, 2019

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.