Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctests to setup.cfg #491

Merged
merged 6 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Apr 12, 2019

  • Make it so that pytest runs doctests in docstrings

@gsheni gsheni requested a review from kmax12 Apr 12, 2019

@gsheni gsheni self-assigned this Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #491 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   96.25%   96.26%   +<.01%     
==========================================
  Files         104      104              
  Lines        8714     8727      +13     
==========================================
+ Hits         8388     8401      +13     
  Misses        326      326
Impacted Files Coverage Δ
featuretools/entityset/timedelta.py 86.42% <ø> (ø) ⬆️
featuretools/entityset/entity.py 96.1% <ø> (ø) ⬆️
featuretools/entityset/entityset.py 95.04% <ø> (ø) ⬆️
featuretools/primitives/api.py 100% <100%> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
...ools/primitives/standard/aggregation_primitives.py 94.82% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62df835...4c1013b. Read the comment docs.

@gsheni gsheni changed the title Update setup.cfg [WIP] Update setup.cfg Apr 12, 2019

@gsheni gsheni changed the title [WIP] Update setup.cfg Add doctests to setup.cfg Apr 12, 2019

gsheni added some commits Apr 12, 2019

@kmax12

kmax12 approved these changes Apr 12, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit d58cdce into master Apr 12, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.25%)
Details
codecov/project 96.26% (+<.01%) compared to 62df835
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the add_pytest_doctest branch Apr 12, 2019

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.