Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform primitives docstring updates #492

Merged
merged 16 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@thehomebrewnerd
Copy link
Contributor

commented Apr 12, 2019

Updated docstrings and added doctests for transform primitives.

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 12, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8862     8862           
=======================================
  Hits         8516     8516           
  Misses        346      346
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️
...uretools/tests/utils_tests/test_list_primitives.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4145c...c704cea. Read the comment docs.

gsheni added some commits Apr 12, 2019

@gsheni gsheni requested review from gsheni and kmax12 Apr 12, 2019

gsheni added some commits Apr 16, 2019

@gsheni

gsheni approved these changes Apr 16, 2019

@kmax12
Copy link
Member

left a comment

Just the one comment about using "base feature" in the doc string. Otherwise, looking good and almost ready to merge.

thehomebrewnerd and others added some commits Apr 17, 2019

@kmax12

kmax12 approved these changes Apr 18, 2019

Copy link
Member

left a comment

Looks good to me. Thanks!

@gsheni gsheni merged commit 14939d1 into Featuretools:master Apr 18, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project 96.09% (+0%) compared to fd4145c
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.