Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI entrypoint #493

Merged
merged 12 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Apr 12, 2019

  • Add entrypoint to add/override cli commands. Featuretools will look at the entrypoints under featuretools_cli, and assuming a dictionary called commands, it will add/override those CLI commands.
    -commands should be a dict with {'name': 'command'). The command should be a function with the @click decorator.
  • running featuretools info in the CLI prints our more information.

@gsheni gsheni changed the title added entrypoint [WIP] Add CLI entrypoint Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #493 into master will decrease coverage by 0.23%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #493      +/-   ##
=========================================
- Coverage   96.34%   96.1%   -0.24%     
=========================================
  Files         106     108       +2     
  Lines        8802    8853      +51     
=========================================
+ Hits         8480    8508      +28     
- Misses        322     345      +23
Impacted Files Coverage Δ
featuretools/__main__.py 0% <0%> (ø) ⬆️
featuretools/tests/utils_tests/test_cli_utils.py 100% <100%> (ø)
featuretools/utils/api.py 100% <100%> (ø) ⬆️
featuretools/utils/cli_utils.py 89.47% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa74be...bf361fa. Read the comment docs.

gsheni added some commits Apr 15, 2019

@gsheni gsheni changed the title [WIP] Add CLI entrypoint Add CLI entrypoint Apr 15, 2019

gsheni added some commits Apr 15, 2019

Show resolved Hide resolved featuretools/utils/cli_utils.py
Show resolved Hide resolved featuretools/__main__.py Outdated

gsheni added some commits Apr 16, 2019

@kmax12

kmax12 approved these changes Apr 16, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit 65fe818 into master Apr 16, 2019

2 of 4 checks passed

codecov/patch 53.84% of diff hit (target 96.34%)
Details
codecov/project 96.1% (-0.24%) compared to 6fa74be
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the add_entrypoint_cli branch Apr 16, 2019

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.