Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryTransform docstrings #495

Merged
merged 10 commits into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@glentennis
Copy link
Contributor

commented Apr 15, 2019

Adding docstrings to BinaryTransform primitives, with a full description, args, and doctests.

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         108      108           
  Lines        8864     8864           
=======================================
  Hits         8517     8517           
  Misses        347      347
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 99.65% <ø> (ø) ⬆️
...uretools/tests/utils_tests/test_list_primitives.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2a8e3...543f8ec. Read the comment docs.

@gsheni gsheni assigned gsheni and unassigned gsheni Apr 16, 2019

@gsheni gsheni self-requested a review Apr 16, 2019

@@ -15,6 +15,18 @@


class GreaterThan(TransformPrimitive):
"""Determines if values X are greater than values Y.

This comment has been minimized.

Copy link
@kmax12

kmax12 Apr 16, 2019

Member

what are X and Y? this should be "Determines if values in one list are greater than another list". fine to keep x and y in extended description below though

let's apply this rule to all the primitives below too

@glentennis glentennis force-pushed the glentennis:Binary-doctrings branch from 7d07989 to 89283d8 Apr 17, 2019

@glentennis glentennis force-pushed the glentennis:Binary-doctrings branch from 81a81d0 to 9719382 Apr 18, 2019

gsheni added some commits Apr 19, 2019

@gsheni gsheni merged commit 5a7e09e into Featuretools:master Apr 19, 2019

4 checks passed

codecov/patch Coverage not affected when comparing dd2a8e3...543f8ec
Details
codecov/project 96.08% remains the same compared to dd2a8e3
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Apr 24, 2019

Merged

v0.7.1 #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.