Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullName #506

Merged
merged 4 commits into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@glentennis
Copy link
Contributor

commented Apr 23, 2019

Adding a new variable type FullName

glentennis added some commits Apr 23, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 23, 2019

Codecov Report

Merging #506 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   96.08%   96.08%   +<.01%     
==========================================
  Files         108      108              
  Lines        8864     8867       +3     
==========================================
+ Hits         8517     8520       +3     
  Misses        347      347
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 87.85% <ø> (ø) ⬆️
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
featuretools/variable_types/variable.py 98.2% <100%> (+0.03%) ⬆️
featuretools/entityset/entity.py 96.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b0840...ec0bd62. Read the comment docs.

@kmax12 kmax12 self-requested a review Apr 24, 2019

@kmax12

kmax12 approved these changes Apr 24, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit 0a88312 into Featuretools:master Apr 24, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.08%)
Details
codecov/project 96.08% (+<.01%) compared to 63b0840
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.