Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NUnique to NumUnique #510

Merged
merged 7 commits into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Apr 24, 2019

  • this is a breaking change to rename the primitive NUnique to NumUnique
@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8881     8881           
=======================================
  Hits         8534     8534           
  Misses        347      347
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.73% <ø> (ø) ⬆️
...ools/primitives/standard/aggregation_primitives.py 94.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ca7b4...acd9088. Read the comment docs.

@gsheni gsheni requested a review from kmax12 Apr 24, 2019

@gsheni gsheni self-assigned this Apr 24, 2019

gsheni and others added some commits Apr 26, 2019

@kmax12
Copy link
Member

left a comment

Implementation looks good.

Before we merge, let's start creating the changelog entry for v0.8.0 and add this code as a breaking change like we did for the 0.7.0 release.

gsheni and others added some commits Apr 29, 2019

@kmax12
Copy link
Member

left a comment

LGTM

@kmax12

kmax12 approved these changes Apr 29, 2019

Copy link
Member

left a comment

LGTM

@gsheni gsheni merged commit 759a3c9 into master Apr 29, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project 96.09% (+0%) compared to 36ca7b4
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the num_unique_renamed branch Apr 29, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

CJStadler added a commit that referenced this pull request Jun 14, 2019

Replace n_unique with num_unique in docs (#599)
The name of the primitive was changed in 759a3c9 (#510), so n_unique is no longer valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.