Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NUnique to NumUnique #510

Merged
merged 7 commits into from Apr 29, 2019
Merged

Rename NUnique to NumUnique #510

merged 7 commits into from Apr 29, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 24, 2019

  • this is a breaking change to rename the primitive NUnique to NumUnique

@codecov
Copy link

codecov bot commented Apr 24, 2019 •
edited

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8881     8881           
=======================================
  Hits         8534     8534           
  Misses        347      347
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.73% <ø> (ø) ⬆️
...ools/primitives/standard/aggregation_primitives.py 94.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ca7b4...acd9088. Read the comment docs.

@gsheni gsheni requested a review from kmax12 April 24, 2019 20:31
@gsheni gsheni self-assigned this Apr 24, 2019
kmax12
kmax12 suggested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good.

Before we merge, let's start creating the changelog entry for v0.8.0 and add this code as a breaking change like we did for the 0.7.0 release.

kmax12
kmax12 previously approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmax12
kmax12 approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit 759a3c9 into master Apr 29, 2019
@gsheni gsheni deleted the num_unique_renamed branch April 29, 2019 21:15
@rwedge rwedge mentioned this pull request May 17, 2019
Merged
@CJStadler CJStadler mentioned this pull request Jun 13, 2019
Merged
CJStadler added a commit that referenced this pull request Jun 14, 2019
@CJStadler
Replace n_unique with num_unique in docs (#599)
8f07396 
The name of the primitive was changed in 759a3c9 (#510), so n_unique is no longer valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @kmax12