Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build_ext code from setup #513

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Apr 25, 2019

To my knowledge featuretools doesn't build any extension modules currently, this code must is left over from early development

rwedge added some commits Apr 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

Merging #513 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         108      108           
  Lines        8867     8867           
=======================================
  Hits         8520     8520           
  Misses        347      347

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2448c38...6cd5e0c. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Apr 25, 2019

@kmax12

kmax12 approved these changes Apr 25, 2019

@rwedge rwedge merged commit e9537ad into master Apr 25, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2448c38...6cd5e0c
Details
codecov/project 96.08% remains the same compared to 2448c38
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the remove-ext-code-from-setup branch Apr 25, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.