Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Primitive Call Tests and NMostCommon Implementation #516

Merged
merged 7 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@CharlesBradshaw
Copy link
Contributor

commented Apr 26, 2019

Fixes #463

@CharlesBradshaw CharlesBradshaw changed the title Updated Tests Updated Primitive Call Tests and NMostCommon Implementation Apr 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #516 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   96.09%   96.09%   -0.01%     
==========================================
  Files         108      108              
  Lines        8893     8881      -12     
==========================================
- Hits         8546     8534      -12     
  Misses        347      347
Impacted Files Coverage Δ
...ools/primitives/standard/aggregation_primitives.py 94.49% <100%> (ø) ⬆️
...tools/tests/primitive_tests/test_primitive_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b528079...f4c740a. Read the comment docs.

@CharlesBradshaw CharlesBradshaw requested a review from rwedge Apr 26, 2019

CharlesBradshaw added some commits Apr 26, 2019

@rwedge

rwedge approved these changes Apr 26, 2019

Copy link
Contributor

left a comment

Looks good!

@CharlesBradshaw CharlesBradshaw merged commit 00b7e9e into master Apr 26, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.9% compared to b528079
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CharlesBradshaw CharlesBradshaw deleted the primitive_call_update branch Apr 26, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.