Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #519

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Apr 29, 2019

  • Add .PHONY target to makefile

@gsheni gsheni requested a review from rwedge Apr 29, 2019

@gsheni gsheni self-assigned this Apr 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 29, 2019

Codecov Report

Merging #519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8881     8881           
=======================================
  Hits         8534     8534           
  Misses        347      347

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b7e9e...854b630. Read the comment docs.

@rwedge

rwedge approved these changes Apr 29, 2019

Copy link
Contributor

left a comment

Looks good

@gsheni gsheni merged commit 37175e2 into master Apr 29, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 00b7e9e...854b630
Details
codecov/project 96.09% remains the same compared to 00b7e9e
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the add_phony_makefile branch Apr 29, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.