Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when target entity does not exist #520

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
3 participants
@CJStadler
Copy link
Contributor

commented Apr 29, 2019

Also improve error message for EntitySets without an id when there is no
entity with the given name.

Resolves #466.

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 29, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Apr 29, 2019

Codecov Report

Merging #520 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #520      +/-   ##
=========================================
+ Coverage   96.09%   96.1%   +<.01%     
=========================================
  Files         108     108              
  Lines        8881    8898      +17     
=========================================
+ Hits         8534    8551      +17     
  Misses        347     347
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.77% <100%> (+0.03%) ⬆️
...uretools/tests/entityset_tests/test_es_metadata.py 96.9% <100%> (+0.13%) ⬆️
featuretools/entityset/entityset.py 95.05% <100%> (+0.01%) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.58% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759a3c9...467f137. Read the comment docs.

Add error message when target entity does not exist
Also improve error message for EntitySets without an id when there is no
entity with the given name.

@CJStadler CJStadler force-pushed the missing-target-entity branch from 13cd701 to ded9c11 Apr 29, 2019

@rwedge rwedge self-requested a review Apr 29, 2019

@rwedge

rwedge approved these changes Apr 29, 2019

Copy link
Contributor

left a comment

Looks good

@CJStadler CJStadler merged commit 269307e into master Apr 29, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project 96.1% (+<.01%) compared to 759a3c9
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the missing-target-entity branch Apr 29, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.