Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter in Entity._handle_time #524

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Apr 30, 2019

columns isn't used by the function so this PR removes it

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #524   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files         108     108           
  Lines        8913    8913           
======================================
  Hits         8566    8566           
  Misses        347     347
Impacted Files Coverage Δ
featuretools/entityset/entity.py 96.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2feb3f...518c42c. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Apr 30, 2019

@rwedge rwedge changed the title Unused param in entity handle time Remove unused paramter in Entity._handle_time Apr 30, 2019

@rwedge rwedge changed the title Remove unused paramter in Entity._handle_time Remove unused parameter in Entity._handle_time Apr 30, 2019

@kmax12

kmax12 approved these changes Apr 30, 2019

Copy link
Member

left a comment

LGTM

@rwedge rwedge merged commit 0b05842 into master Apr 30, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.1%)
Details
codecov/project 96.1% (+0%) compared to f2feb3f
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the unused-param-in-entity-handle-time branch Apr 30, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.