Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatetimeTimeIndex, Discrete to ALL Variable Types #526

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented May 2, 2019

  • Add DatetimeTimeIndex, Discrete to ALL Variable Types

@gsheni gsheni requested a review from kmax12 May 2, 2019

@gsheni gsheni self-assigned this May 2, 2019

@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #526   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files         108     108           
  Lines        8913    8913           
======================================
  Hits         8566    8566           
  Misses        347     347
Impacted Files Coverage Δ
featuretools/variable_types/variable.py 98.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aec2e9...35d145b. Read the comment docs.

@kmax12

kmax12 approved these changes May 2, 2019

@gsheni gsheni merged commit 9ea2ed1 into master May 2, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 9aec2e9...35d145b
Details
codecov/project 96.1% remains the same compared to 9aec2e9
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the add_to_all_v branch May 2, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.