Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all relative imports and use absolute location #530

Merged
merged 10 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented May 3, 2019

  • Removed all relative imports and specify absolute location

gsheni added some commits May 3, 2019

@gsheni gsheni self-assigned this May 3, 2019

@rwedge rwedge requested a review from kmax12 May 3, 2019

@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #530 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   96.29%   96.29%   -0.01%     
==========================================
  Files         115      115              
  Lines        9162     9151      -11     
==========================================
- Hits         8823     8812      -11     
  Misses        339      339
Impacted Files Coverage Δ
.../tests/primitive_tests/test_features_serializer.py 100% <ø> (ø) ⬆️
...ests/primitive_tests/test_features_deserializer.py 100% <ø> (ø) ⬆️
...ls/tests/primitive_tests/test_identity_features.py 100% <ø> (ø) ⬆️
featuretools/entityset/entity.py 96.12% <100%> (ø) ⬆️
featuretools/entityset/entityset.py 95.08% <100%> (ø) ⬆️
featuretools/feature_base/features_deserializer.py 97.95% <100%> (ø) ⬆️
...eaturetools/computational_backends/feature_tree.py 100% <100%> (ø) ⬆️
featuretools/primitives/base/primitive_base.py 100% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.3% <100%> (ø) ⬆️
featuretools/entityset/deserialize.py 100% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbff58e...66ac6af. Read the comment docs.

gsheni and others added some commits May 6, 2019

@kmax12 kmax12 removed their request for review May 13, 2019

@rwedge

rwedge approved these changes May 13, 2019

Copy link
Contributor

left a comment

Looks good

@gsheni gsheni merged commit 8ebc46a into master May 13, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.29%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.7% compared to cbff58e
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the fix_relative_imports branch May 13, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.