Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entityset fixture refactor #539

Merged
merged 31 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented May 9, 2019

Resolves #484

instead of creating another es or entityset fixture in every test file now any test in the test folder can use the es fixture for the mock entityset and int_es for the numeric time index mock entityset.

I also removed scope=module from other fixtures so that fixture modification isn't something that needs to be though considered.

rwedge added some commits May 9, 2019

@codecov

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #539 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   96.26%   96.29%   +0.03%     
==========================================
  Files         114      115       +1     
  Lines        9256     9162      -94     
==========================================
- Hits         8910     8823      -87     
+ Misses        346      339       -7
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_entity.py 100% <ø> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.31% <ø> (+0.19%) ⬆️
...ools/tests/primitive_tests/test_direct_features.py 100% <ø> (ø) ⬆️
...ests/primitive_tests/test_feature_serialization.py 100% <ø> (ø) ⬆️
...aturetools/tests/entityset_tests/test_timedelta.py 100% <ø> (ø) ⬆️
...aturetools/tests/primitive_tests/test_overrides.py 100% <ø> (ø) ⬆️
...imitive_tests/test_groupby_transform_primitives.py 100% <ø> (ø) ⬆️
...ools/tests/entityset_tests/test_last_time_index.py 100% <100%> (ø) ⬆️
featuretools/tests/dfs_tests/test_dfs_method.py 100% <100%> (+1.58%) ⬆️
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429adb0...0d226e0. Read the comment docs.

@rwedge rwedge requested a review from CJStadler May 10, 2019

@CJStadler
Copy link
Contributor

left a comment

Looks good! Back to you @rwedge

rwedge and others added some commits May 10, 2019

@CJStadler
Copy link
Contributor

left a comment

👍

@rwedge rwedge merged commit cbff58e into master May 10, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.26%)
Details
codecov/project 96.29% (+0.03%) compared to 429adb0
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the entityset-fixture-refactor branch May 10, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.