Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New demo links #542

Merged
merged 12 commits into from May 17, 2019

Conversation

Projects
None yet
3 participants
@gsheni
Copy link
Contributor

commented May 13, 2019

  • fix demo links

gsheni added some commits May 13, 2019

WIP

@gsheni gsheni requested review from kmax12 and rwedge May 13, 2019

@gsheni gsheni self-assigned this May 13, 2019

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #542 into master will increase coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   96.29%   96.31%   +0.02%     
==========================================
  Files         115      115              
  Lines        9151     9156       +5     
==========================================
+ Hits         8812     8819       +7     
+ Misses        339      337       -2
Impacted Files Coverage Δ
featuretools/primitives/utils.py 97.36% <ø> (ø) ⬆️
featuretools/demo/flight.py 96.15% <100%> (+1.09%) ⬆️
featuretools/demo/retail.py 94.73% <100%> (+9.73%) ⬆️
featuretools/tests/demo_tests/test_demo_data.py 96.55% <88.88%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c42ec...e500bd2. Read the comment docs.

gsheni added some commits May 13, 2019

@kmax12
Copy link
Member

left a comment

LGTM

@rwedge
Copy link
Contributor

left a comment

Looks good

@rwedge

rwedge approved these changes May 17, 2019

@gsheni gsheni merged commit 796e102 into master May 17, 2019

3 of 4 checks passed

codecov/patch 94.11% of diff hit (target 96.29%)
Details
codecov/project 96.31% (+0.02%) compared to 96c42ec
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the new_demo_links branch May 17, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.