Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add relationship_path to agg and direct features #544
This adds an optional constructor parameter, and stores the
This does not update any other logic to use the paths, as this will be added in later commits.
See #543 for context.
@@ Coverage Diff @@ ## master #544 +/- ## ========================================== + Coverage 96.35% 96.46% +0.11% ========================================== Files 116 117 +1 Lines 9234 9511 +277 ========================================== + Hits 8897 9175 +278 + Misses 337 336 -1
kmax12 left a comment •
the overall approach looks good. I left a few comments about methods that were implemented that look similar to stuff we already have. In particular, I wonder if there is overlap with the path find logic and the methods we already have on