Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary time_last variable #546

Merged
merged 2 commits into from May 20, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented May 17, 2019

We just grouped on this column, so it should be equal to the group
identifier. This removes the variable which was called time_last, but
renames the group id to now be time_last.

Remove unecessary time_last variable
We just grouped on this column, so it should be equal to the group
identifier. This removes the variable which was called time_last, but
renames the group id to now be time_last.
@codecov

This comment has been minimized.

Copy link

commented May 17, 2019

Codecov Report

Merging #546 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   96.31%   96.31%   -0.01%     
==========================================
  Files         115      115              
  Lines        9156     9155       -1     
==========================================
- Hits         8819     8818       -1     
  Misses        337      337
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 97.91% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2546a68...3be7ee1. Read the comment docs.

@kmax12 kmax12 self-requested a review May 17, 2019

@kmax12

kmax12 approved these changes May 17, 2019

Copy link
Member

left a comment

LGTM

@kmax12

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@CJStadler let's wait to merge until after the next release

@CJStadler CJStadler self-assigned this May 17, 2019

@CJStadler CJStadler merged commit 0f7b917 into master May 20, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.31%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.68% compared to 2546a68
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the remove-extra-time-last branch May 20, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.