Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifies error when 'make_time_index' is an invalid string (#537) #550

Merged
merged 8 commits into from May 21, 2019

Conversation

Projects
None yet
3 participants
@ctduffy
Copy link
Contributor

commented May 20, 2019

Fixes #537
If the user's input into the "make_time_index" is invalid, gives more specific error as to why.

@CLAassistant

This comment has been minimized.

Copy link

commented May 20, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #550 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   96.31%   96.31%   -0.01%     
==========================================
  Files         115      115              
  Lines        9155     9167      +12     
==========================================
+ Hits         8818     8829      +11     
- Misses        337      338       +1
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 94.93% <100%> (-0.15%) ⬇️
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7b917...e57d97e. Read the comment docs.

@gsheni
Copy link
Contributor

left a comment

Other than my comments, looks good.

Show resolved Hide resolved featuretools/entityset/entityset.py
Show resolved Hide resolved featuretools/entityset/entityset.py Outdated

@gsheni gsheni self-requested a review May 20, 2019

ctduffy added some commits May 21, 2019

@gsheni gsheni dismissed their stale review via e57d97e May 21, 2019

@gsheni

gsheni approved these changes May 21, 2019

@gsheni gsheni merged commit a7395a1 into master May 21, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.31%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.68% compared to 0f7b917
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the make_time_index_check branch May 21, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.