Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra requirements #551

Merged
merged 9 commits into from May 21, 2019

Conversation

Projects
None yet
3 participants
@gsheni
Copy link
Contributor

commented May 20, 2019

  • Add extra requirements for featuretools plugins

@gsheni gsheni self-assigned this May 20, 2019

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files         115      115           
  Lines        9167     9167           
=======================================
  Hits         8829     8829           
  Misses        338      338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51cdf87...6f8e32e. Read the comment docs.

@gsheni gsheni requested review from kmax12 and rwedge May 20, 2019

@rwedge

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Should we test installing these extras as part of our CI tests?

gsheni added some commits May 21, 2019

@gsheni

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@rwedge PR now tests importing the extra packages.

Show resolved Hide resolved .circleci/config.yml Outdated
Show resolved Hide resolved .circleci/config.yml
Show resolved Hide resolved .circleci/config.yml

gsheni added some commits May 21, 2019

@kmax12

kmax12 approved these changes May 21, 2019

Copy link
Member

left a comment

LGTM

addressed

@kmax12 kmax12 merged commit 6cdf010 into master May 21, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 51cdf87...6f8e32e
Details
codecov/project 96.31% remains the same compared to 51cdf87
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@kmax12 kmax12 deleted the add_extra_reqs branch May 21, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.