Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates TimeSincePrevious and Diff Primitives #561

Merged
merged 17 commits into from May 23, 2019

Conversation

Projects
None yet
3 participants
@ctduffy
Copy link
Contributor

commented May 23, 2019

fixes #501

@ctduffy ctduffy requested a review from rwedge May 23, 2019

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #561 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   96.36%   96.35%   -0.01%     
==========================================
  Files         116      116              
  Lines        9262     9244      -18     
==========================================
- Hits         8925     8907      -18     
  Misses        337      337
Impacted Files Coverage Δ
...s/tests/primitive_tests/test_transform_features.py 98.31% <100%> (ø) ⬆️
...turetools/computational_backends/pandas_backend.py 98.06% <100%> (-0.02%) ⬇️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 100% <100%> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c139527...f644e22. Read the comment docs.

@rwedge
Copy link
Contributor

left a comment

In general, the tests that used Diff / TimeSincePrevious should use GroupByTransformFeature so that we do not need to change the test answers.

@ctduffy

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

fixed issues brought up by @rwedge

@ctduffy

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@rwedge fixed test cases

ctduffy and others added some commits May 23, 2019

@rwedge
Copy link
Contributor

left a comment

Looks good

@kmax12 kmax12 self-requested a review May 23, 2019

@ctduffy

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@kmax12 fixed the timesinceprevious units and removed the diff date example

@kmax12

kmax12 approved these changes May 23, 2019

Copy link
Member

left a comment

LGTM

@ctduffy ctduffy merged commit 0fc1c00 into master May 23, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@ctduffy ctduffy deleted the issue501 branch May 23, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.