Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed testing issue with residual directories causing FileExistsError for makedirs() #569

Merged
merged 7 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@allisonportis
Copy link
Contributor

commented May 29, 2019

Fix #565
Resolved by adding fixture that creates the path and makes the directory, yields the path, and removes the path folder in the finalization code.

@codecov

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

Merging #569 into master will decrease coverage by 0.03%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   96.46%   96.43%   -0.04%     
==========================================
  Files         117      117              
  Lines        9511     9505       -6     
==========================================
- Hits         9175     9166       -9     
- Misses        336      339       +3
Impacted Files Coverage Δ
...etools/tests/entityset_tests/test_serialization.py 96.25% <88.46%> (-3.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f441b...5aa3bf4. Read the comment docs.

allisonportis and others added some commits May 29, 2019

try:
os.makedirs(path)
except OSError as e:
if e.errno != errno.EEXIST:

This comment has been minimized.

Copy link
@rwedge

rwedge May 29, 2019

Contributor

could you add a comment describing what EEXIST refers to?

@rwedge

rwedge approved these changes May 29, 2019

Copy link
Contributor

left a comment

Looks good

@allisonportis allisonportis merged commit ec567c2 into master May 30, 2019

2 of 4 checks passed

codecov/patch 88.46% of diff hit (target 96.46%)
Details
codecov/project 96.43% (-0.04%) compared to 26f441b
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.