Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Variable Types #571

Merged
merged 9 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@allisonportis
Copy link
Contributor

commented May 30, 2019

Issue #560

Added to entityset/deserialize.py so that description_to_variable() looks at all variables that are (recursively) a subclass of Variable, so that it will recognize custom variable types.

allisonportis added some commits May 29, 2019

Update to current master
Merge branch 'master' of https://github.com/Featuretools/featuretools into custom_variable_types
@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #571 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +<.01%     
==========================================
  Files         117      117              
  Lines        9518     9534      +16     
==========================================
+ Hits         9179     9195      +16     
  Misses        339      339
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 100% <ø> (ø) ⬆️
...etools/tests/entityset_tests/test_serialization.py 96.84% <100%> (+0.59%) ⬆️
featuretools/primitives/utils.py 97.24% <100%> (-0.13%) ⬇️
featuretools/utils/gen_utils.py 89.79% <100%> (+1.15%) ⬆️
featuretools/entityset/deserialize.py 100% <100%> (ø) ⬆️
featuretools/variable_types/variable.py 98.21% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f75909...3f28790. Read the comment docs.

Show resolved Hide resolved featuretools/entityset/serialize.py Outdated
Show resolved Hide resolved featuretools/entityset/serialize.py Outdated
Show resolved Hide resolved featuretools/entityset/deserialize.py Outdated
Show resolved Hide resolved featuretools/entityset/serialize.py Outdated

allisonportis and others added some commits May 30, 2019

@rwedge

rwedge approved these changes May 30, 2019

Copy link
Contributor

left a comment

Looks good

@allisonportis

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Hi @bschreck, we implemented a solution for custom variable types. Would you mind testing out this branch and see if it's working for you? Thanks!

@bschreck

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@allisonportis This works great, thanks for the change!

@allisonportis allisonportis merged commit 1c00b98 into master Jun 4, 2019

4 checks passed

codecov/patch 100% of diff hit (target 96.43%)
Details
codecov/project 96.44% (+<.01%) compared to 8f75909
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@allisonportis allisonportis deleted the custom_variable_types branch Jun 4, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.