Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty directory tests/synthesis #574

Merged
merged 4 commits into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented May 31, 2019

Alternatively, we could rename tests/dfs_tests to tests/synthesis to match featuretools/synthesis.

@codecov

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files         117      117           
  Lines        9518     9518           
=======================================
  Hits         9179     9179           
  Misses        339      339
Impacted Files Coverage Δ
featuretools/tests/synthesis/test_dfs_method.py 100% <ø> (ø)
...aturetools/tests/synthesis/test_encode_features.py 100% <ø> (ø)
...ols/tests/synthesis/test_deep_feature_synthesis.py 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96303b7...92423e9. Read the comment docs.

@rwedge

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I like the tests/synthesis idea. Can you move test_encode_features.py into that folder as well, since encode_features is also part of the synthesis module?

CJStadler added some commits Jun 3, 2019

Move to tests/synthesis
Also move test_encode_features.py
Merge branch 'remove-empty-synthesis-dir' of github.com:Featuretools/…
…featuretools into remove-empty-synthesis-dir
@rwedge

rwedge approved these changes Jun 3, 2019

Copy link
Contributor

left a comment

Looks good

@CJStadler CJStadler merged commit de1da26 into master Jun 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 96303b7...92423e9
Details
codecov/project 96.43% remains the same compared to 96303b7
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the remove-empty-synthesis-dir branch Jun 3, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.