Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error message for index/time_index being same column in norm… #583

Merged
merged 9 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@alexjwang
Copy link
Contributor

commented Jun 5, 2019

Fixing #553

improved error message for index/time_index being same column in norm…
…alize_entity and entity_from_dataframe
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@d289fef). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #583   +/-   ##
=========================================
  Coverage          ?   96.44%           
=========================================
  Files             ?      117           
  Lines             ?     9539           
  Branches          ?        0           
=========================================
  Hits              ?     9200           
  Misses            ?      339           
  Partials          ?        0
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 95.01% <100%> (ø)
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d289fef...0b59893. Read the comment docs.

Show resolved Hide resolved featuretools/entityset/entityset.py Outdated
Show resolved Hide resolved featuretools/entityset/entityset.py
Show resolved Hide resolved featuretools/tests/entityset_tests/test_es.py Outdated
@gsheni
Copy link
Contributor

left a comment

Other than the 1 comment, looks good!

Show resolved Hide resolved featuretools/tests/entityset_tests/test_es.py Outdated

@gsheni gsheni dismissed their stale review via ec193b6 Jun 10, 2019

gsheni added some commits Jun 10, 2019

@rwedge

rwedge approved these changes Jun 11, 2019

Copy link
Contributor

left a comment

Looks good

@gsheni gsheni merged commit f470ed3 into master Jun 11, 2019

3 checks passed

changelog_updated Workflow: changelog_updated
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the index_error_msg branch Jun 11, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.