Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip changelog CI check on master branch #584

Merged
merged 4 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented Jun 5, 2019

Pull Request Description

When we run CircleCI after merging into the master branch the changelog_updated check fails because there is no pull request number. This PR filters out running the changelog_updated check on the master branch.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

rwedge added some commits Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         117      117           
  Lines        9534     9534           
=======================================
  Hits         9195     9195           
  Misses        339      339

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3012f...0ebbadf. Read the comment docs.

rwedge added some commits Jun 5, 2019

@rwedge rwedge changed the title [WIP] skip changelog CI check on master branch Skip changelog CI check on master branch Jun 5, 2019

@rwedge rwedge requested a review from gsheni Jun 5, 2019

@gsheni

gsheni approved these changes Jun 5, 2019

@rwedge rwedge merged commit 86e6d2b into master Jun 5, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch Coverage not affected when comparing 6e3012f...0ebbadf
Details
codecov/project 96.44% remains the same compared to 6e3012f
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the skip-changelog-ci-check-on-master branch Jun 5, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.