Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed features have names correctly serialized #585

Merged
merged 17 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@alexjwang
Copy link
Contributor

commented Jun 5, 2019

fixed #568

Created new branch (same as #580 ) as #580 has commits from #581

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #585 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   96.44%   96.46%   +0.02%     
==========================================
  Files         117      117              
  Lines        9536     9565      +29     
==========================================
+ Hits         9197     9227      +30     
+ Misses        339      338       -1
Impacted Files Coverage Δ
...ls/tests/primitive_tests/test_identity_features.py 100% <ø> (ø) ⬆️
...aturetools/tests/primitive_tests/test_agg_feats.py 99.35% <ø> (ø) ⬆️
...imitive_tests/test_groupby_transform_primitives.py 100% <ø> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.32% <ø> (ø) ⬆️
...ools/tests/primitive_tests/test_direct_features.py 100% <ø> (ø) ⬆️
.../tests/primitive_tests/test_features_serializer.py 100% <100%> (ø) ⬆️
...ests/primitive_tests/test_feature_serialization.py 100% <100%> (ø) ⬆️
featuretools/feature_base/features_serializer.py 100% <100%> (ø) ⬆️
featuretools/feature_base/feature_base.py 97.56% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f470ed3...4992ad0. Read the comment docs.

alexjwang added some commits Jun 5, 2019

@gsheni
Copy link
Contributor

left a comment

Other than the 1 minor comment, looks good.

Show resolved Hide resolved featuretools/feature_base/feature_base.py Outdated
@gsheni
Copy link
Contributor

left a comment

lgtm

@CJStadler

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

@gsheni and @alexjwang is there anything blocking this? There was just an issue posted about it (#597) so it would be good to get it into the next release if possible.

@gsheni

gsheni approved these changes Jun 13, 2019

Copy link
Contributor

left a comment

looks good. merging

@gsheni gsheni merged commit 11dbb41 into master Jun 13, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 96.44%)
Details
codecov/project 96.46% (+0.02%) compared to f470ed3
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the renamed_serialize branch Jun 13, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.