Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema version added for entityset serialization #586

Merged
merged 10 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@alexjwang
Copy link
Contributor

commented Jun 5, 2019

fixes #556

alexjwang added some commits Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #586 into master will increase coverage by 0.01%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   96.44%   96.46%   +0.01%     
==========================================
  Files         117      117              
  Lines        9534     9578      +44     
==========================================
+ Hits         9195     9239      +44     
  Misses        339      339
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 100% <100%> (ø) ⬆️
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø) ⬆️
featuretools/feature_base/features_deserializer.py 100% <100%> (+1.75%) ⬆️
featuretools/entityset/deserialize.py 100% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 91.54% <95.45%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e6d2b...863107e. Read the comment docs.

alexjwang added some commits Jun 5, 2019

Show resolved Hide resolved featuretools/entityset/deserialize.py Outdated
@gsheni

gsheni approved these changes Jun 13, 2019

@gsheni gsheni merged commit 5ff1127 into master Jun 13, 2019

3 checks passed

changelog_updated Workflow: changelog_updated
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the schema#556 branch Jun 13, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.