Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed all mentions of allow_where #587

Merged
merged 4 commits into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@alexjwang
Copy link
Contributor

commented Jun 6, 2019

Fixes #474

Removed:
allow_where variable in aggregation_primitive_base.py
allow_where variable in primitive_base.py
test_allow_where() entire function in test_deep_feature_synthesis.py

alexjwang added some commits Jun 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #587 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   96.44%   96.43%   -0.01%     
==========================================
  Files         117      117              
  Lines        9534     9522      -12     
==========================================
- Hits         9195     9183      -12     
  Misses        339      339
Impacted Files Coverage Δ
...ools/primitives/base/aggregation_primitive_base.py 100% <ø> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 96.74% <ø> (-0.02%) ⬇️
featuretools/primitives/base/primitive_base.py 100% <ø> (ø) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e6d2b...eb0b35a. Read the comment docs.

@gsheni

gsheni approved these changes Jun 6, 2019

Copy link
Contributor

left a comment

looks good.

@alexjwang alexjwang merged commit 8d91985 into master Jun 6, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 96.44%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.55% compared to 86e6d2b
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the remove_allow_where branch Jun 11, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.