Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace n_unique with num_unique in docs #599

Merged
merged 3 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jun 13, 2019

The name of the primitive was changed in #510, so n_unique is no longer valid.

CJStadler added some commits Jun 13, 2019

Replace n_unique with num_unique in docs
The name of the primitive was changed in 759a3c9.
@codecov

This comment has been minimized.

Copy link

commented Jun 13, 2019

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         117      117           
  Lines        9609     9609           
=======================================
  Hits         9271     9271           
  Misses        338      338
Impacted Files Coverage Δ
featuretools/wrappers/sklearn.py 95.65% <ø> (ø) ⬆️
featuretools/synthesis/dfs.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff1127...90f7168. Read the comment docs.

@gsheni

gsheni approved these changes Jun 14, 2019

Copy link
Contributor

left a comment

looks good

@CJStadler CJStadler merged commit 8f07396 into master Jun 14, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch Coverage not affected when comparing 5ff1127...90f7168
Details
codecov/project 96.48% remains the same compared to 5ff1127
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the docs-n-unique branch Jun 14, 2019

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.