Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of features applied to Index features #602

Merged
merged 3 commits into from Jun 19, 2019

Conversation

Projects
None yet
4 participants
@CJStadler
Copy link
Contributor

commented Jun 18, 2019

If the primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.

See #600 (comment)

Change type of features applied to Index features
If the primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.
@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #602 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #602      +/-   ##
=========================================
+ Coverage    96.4%   96.4%   +<.01%     
=========================================
  Files         119     119              
  Lines        9643    9648       +5     
=========================================
+ Hits         9296    9301       +5     
  Misses        347     347
Impacted Files Coverage Δ
featuretools/feature_base/feature_base.py 97.63% <100%> (+0.01%) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b84b66...beb8423. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #602 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   96.34%   96.34%   +<.01%     
==========================================
  Files         119      119              
  Lines        9661     9666       +5     
==========================================
+ Hits         9308     9313       +5     
  Misses        353      353
Impacted Files Coverage Δ
featuretools/feature_base/feature_base.py 97.63% <100%> (+0.01%) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a47d0...a003582. Read the comment docs.

@CJStadler CJStadler requested a review from kmax12 Jun 18, 2019

@kmax12
Copy link
Member

left a comment

This looks good.

Let's hold off merging until the next release goes out

@CJStadler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@kmax12 is this ready now? (needs to be re-approved)

@kmax12

kmax12 approved these changes Jun 19, 2019

@@ -5,6 +5,7 @@ Changelog
**Future Release**
* Enhancements
* Fixes
* Change type of features calculated on Index features to Categorical (:pr:`602`)

This comment has been minimized.

Copy link
@rwedge

rwedge Jun 19, 2019

Contributor

This needs to be indented more to register as a sublist

@CJStadler CJStadler merged commit 7ed156f into master Jun 19, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 96.34%)
Details
codecov/project 96.34% (+<.01%) compared to c5a47d0
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the feature-type-on-index branch Jun 19, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Change type of features applied to Index features (Featuretools#602)
If a primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.