Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change time since return type to numeric #606

Merged
merged 2 commits into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

commented Jun 19, 2019

Currently, the primitive annotation says Timedelta. It should be numeric.

kmax12 added some commits Jun 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #606 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         119      119           
  Lines        9661     9661           
=======================================
  Hits         9308     9308           
  Misses        353      353
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26bf38b...0a1420a. Read the comment docs.

@rwedge

rwedge approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

Looks good

@kmax12 kmax12 merged commit 4659af8 into master Jun 19, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 96.34%)
Details
codecov/project 96.34% (+0%) compared to 26bf38b
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Jun 19, 2019

Merged

v0.9.0 #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.