Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variance_selection.py #613

Merged
merged 4 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jun 19, 2019

This is not referenced anywhere else.

The commit that added it (99a80d7) seems unrelated, was it added accidentally?

Remove variance_selection.py
This is not referenced anywhere else, and the commit message (99a80d7)
does not mention it so it may have been added accidentally.
@kmax12

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

It's just legacy stuff from the early days. We can remove it now

@kmax12 kmax12 self-requested a review Jun 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #613 into master will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   96.34%   97.12%   +0.77%     
==========================================
  Files         119      118       -1     
  Lines        9666     9589      -77     
==========================================
  Hits         9313     9313              
+ Misses        353      276      -77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2204f0e...1404543. Read the comment docs.

CJStadler added some commits Jun 20, 2019

Merge branch 'remove-variance-selection' of github.com:Featuretools/f…
…eaturetools into remove-variance-selection
@kmax12

kmax12 approved these changes Jun 20, 2019

@CJStadler CJStadler merged commit b4e0642 into master Jun 20, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch Coverage not affected when comparing 2204f0e...1404543
Details
codecov/project 97.12% (+0.77%) compared to 2204f0e
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the remove-variance-selection branch Jun 20, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.