Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select columns from dataframe using a list #615

Merged
merged 3 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jun 20, 2019

Previously the columns were in a set, but this does not work on pandas 0.23.

Fixes #614

Select columns from dataframe using a list
Previously the columns were in a set, but this doesn not work on pandas
0.23.
@codecov

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         119      119           
  Lines        9666     9666           
=======================================
  Hits         9313     9313           
  Misses        353      353
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed156f...237892c. Read the comment docs.

features = [self.feature_set.features_by_name[name]
for name in feature_names]
features = (self.feature_set.features_by_name[name]
for name in feature_names)

This comment has been minimized.

Copy link
@CJStadler

CJStadler Jun 20, 2019

Author Contributor

This was creating a list unnecessarily, not related to the issue here.

CJStadler added some commits Jun 20, 2019

@kmax12 kmax12 self-requested a review Jun 20, 2019

@kmax12

kmax12 approved these changes Jun 20, 2019

Copy link
Member

left a comment

LGTM

@kmax12 kmax12 merged commit 2204f0e into master Jun 20, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 96.34%)
Details
codecov/project 96.34% (+0%) compared to 7ed156f
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Select columns from dataframe using a list (Featuretools#615)
* Select columns from dataframe using a list

Previously the columns were in a set, but this doesn not work on pandas
0.23.

* Update changelog

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.