Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timedelta data param #619

Merged
merged 4 commits into from Jun 21, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jun 21, 2019

Constructing a Timedelta with data via __call__ was removed in #572 ,
so this is no longer used.

Resolves #592

CJStadler added some commits Jun 21, 2019

Remove Timedelta data param
Constructing a Timedelta with data via __call__ was removed in 3b84b66,
so this is no longer used.
@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2019

Codecov Report

Merging #619 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   97.27%   97.42%   +0.15%     
==========================================
  Files         118      118              
  Lines        9545     9526      -19     
==========================================
- Hits         9285     9281       -4     
+ Misses        260      245      -15
Impacted Files Coverage Δ
featuretools/exceptions.py 66.66% <ø> (ø) ⬆️
featuretools/entityset/timedelta.py 87.2% <100%> (+8.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321a0f4...cce43e7. Read the comment docs.

@kmax12

kmax12 approved these changes Jun 21, 2019

Copy link
Member

left a comment

LGTM

@CJStadler CJStadler merged commit f51d883 into master Jun 21, 2019

5 checks passed

changelog_updated Workflow: changelog_updated
Details
codecov/patch 100% of diff hit (target 97.27%)
Details
codecov/project 97.42% (+0.15%) compared to 321a0f4
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the remove-timedelta-data branch Jun 21, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Remove Timedelta data param (Featuretools#619)
Constructing a Timedelta with data via __call__ was removed in 3b84b66,
so this is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.