Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter entity df through forward relationship in CFM #625

Merged
merged 3 commits into from Jun 26, 2019

Conversation

Projects
None yet
3 participants
@CJStadler
Copy link
Contributor

commented Jun 25, 2019

If the current entity node uses the full entity df we were filtering the
parent using the values from the full df instead of the filtered df.
This resulted in calculating features on the full df unnecessarily.

This bug seems so obvious I'm wondering whether it was just missed
in #598 , or if there is a legitimate reason not to do this through
forward paths which I am now forgetting.

CJStadler added some commits Jun 25, 2019

Filter entity df through forward relationship in CFM
If the current entity node uses the full entity df we were filtering the
parent using the values from the full df instead of the filtered df.
This resulted in calculating features on the full df unnecessarily.
@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9532     9532           
=======================================
  Hits         9287     9287           
  Misses        245      245
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376c373...b912cc5. Read the comment docs.

@kmax12
Copy link
Member

left a comment

LGTM

@gsheni

gsheni approved these changes Jun 26, 2019

@gsheni gsheni merged commit 1f6d9ed into master Jun 26, 2019

4 checks passed

codecov/patch 100% of diff hit (target 97.42%)
Details
codecov/project 97.42% (+0%) compared to 376c373
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the fix-filter-values-forward-relationship branch Jun 26, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Filter entity df through forward relationship in CFM (Featuretools#625)
* Filter entity df through forward relationship in CFM

If the current entity node uses the full entity df we were filtering the
parent using the values from the full df instead of the filtered df.
This resulted in calculating features on the full df unnecessarily.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.